linux-ext4 - Re: [ext4:dev 40/60] fs/ext4/inode.c:1953 __ext4_journalled_writepage() error: potential NULL dereference 'page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121205083141.GJ22569@mwanda>
Date:	Wed, 5 Dec 2012 11:31:41 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	Tao Ma <tm@....ma>, linux-ext4@...r.kernel.org
Subject: Re: [ext4:dev 40/60] fs/ext4/inode.c:1953
 __ext4_journalled_writepage() error: potential NULL dereference 'page_bufs'.

On Wed, Dec 05, 2012 at 12:41:25AM -0500, Theodore Ts'o wrote:
> On Tue, Dec 04, 2012 at 04:56:02PM +0300, Dan Carpenter wrote:
> > It looks good.
> > 
> > Like I mentioned before Smatch doesn't understand
> > ext4_has_inline_data() so it still complains later on in the
> > function.  But it's now obvious to a human reader that there won't
> > be a NULL dereference.
> 
> This is what I plan to fold into the patch.  It should make it easier
> for gcc to produce optimized code, as well as being easier to
> understand.   Hopefully this should also keep smatch happy.
> 

Yeah, moving the check for (inode_bh == NULL) forward is nice.
Thanks.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html