lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 5 Dec 2012 11:25:10 -0500
From:	Theodore Ts'o <>
To:	Dan Carpenter <>
Cc:	Tao Ma <>,
Subject: Re: [ext4:dev 40/60] fs/ext4/inode.c:1953
 __ext4_journalled_writepage() error: potential NULL dereference 'page_bufs'.

On Wed, Dec 05, 2012 at 11:31:41AM +0300, Dan Carpenter wrote:
> Yeah, moving the check for (inode_bh == NULL) forward is nice.
> Thanks.

Not that I really care about optimizing the error path that much, but
getting a starting a handle only to immediately stop it again if
inode_bh == NULL was just silly.  :-)

							- Ted
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists