linux-ext4 - Re: [PATCH] resize2fs: add debug switch to use old online interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130112003027.GA9550@thunk.org>
Date:	Fri, 11 Jan 2013 19:30:27 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Carlos Maiolino <cmaiolino@...hat.com>
Subject: Re: [PATCH] resize2fs: add debug switch to use old online interface

On Fri, Jan 11, 2013 at 11:52:53AM -0600, Eric Sandeen wrote:
> --- a/resize/resize2fs.h
> +++ b/resize/resize2fs.h
> @@ -76,6 +76,8 @@ typedef struct ext2_sim_progress *ext2_sim_progmeter;
>  #define RESIZE_DEBUG_BMOVE		0x0002
>  #define RESIZE_DEBUG_INODEMAP		0x0004
>  #define RESIZE_DEBUG_ITABLEMOVE		0x0008
> +/* old online resize interface */
> +#define RESIZE_DEBUG_OLD		0x0010

0x0010 is already used for

#define RESIZE_DEBUG_RTRACK		0x0010

(which is very useful for performance tuning resize2fs).

I wonder if we would be better off using a environment variable for
this?  Mainly because currently, the current resize flags don't
actually change the behavior of resize2fs, but just add different
levels of debugging messages. 

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html