linux-ext4 - Re: [PATCH] ext4: trigger the lazy inode table initialization after resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130114130415.GB3906@andromeda.usersys.redhat.com>
Date:	Mon, 14 Jan 2013 11:04:15 -0200
From:	Carlos Maiolino <cmaiolino@...hat.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	esandeen@...hat.com
Subject: Re: [PATCH] ext4: trigger the lazy inode table initialization after
 resize

Hi,

> @@ -358,6 +361,7 @@ group_add_out:
>  		ext4_fsblk_t n_blocks_count;
>  		struct super_block *sb = inode->i_sb;
>  		int err = 0, err2 = 0;
> +		ext4_group_t o_group = EXT4_SB(sb)->s_groups_count;
>  
>  		if (EXT4_HAS_RO_COMPAT_FEATURE(sb,
>  			       EXT4_FEATURE_RO_COMPAT_BIGALLOC)) {
> @@ -388,6 +392,11 @@ group_add_out:
>  		if (err == 0)
>  			err = err2;
>  		mnt_drop_write_file(filp);
> +		if (!err && (o_group > EXT4_SB(sb)->s_groups_count) &&

Maybe a n00b question Ted, but can o_group here be bigger than ->s_groups_count
in any chance? 


The patch looks good,

Reviewed-by: Carlos Maiolino <cmaiolino@...hat.com>

-- 
Carlos
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html