linux-ext4 - Re: [PATCH] ext4: trigger the lazy inode table initialization after resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130114143317.GE12052@thunk.org>
Date:	Mon, 14 Jan 2013 09:33:17 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Carlos Maiolino <cmaiolino@...hat.com>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	esandeen@...hat.com
Subject: Re: [PATCH] ext4: trigger the lazy inode table initialization after
 resize

On Mon, Jan 14, 2013 at 11:04:15AM -0200, Carlos Maiolino wrote:
> > @@ -388,6 +392,11 @@ group_add_out:
> >  		if (err == 0)
> >  			err = err2;
> >  		mnt_drop_write_file(filp);
> > +		if (!err && (o_group > EXT4_SB(sb)->s_groups_count) &&
> 
> Maybe a n00b question Ted, but can o_group here be bigger than ->s_groups_count
> in any chance? 

o_group can never be smaller than s_groups_count (since we don't
support online shrink).  o_group can be larger than s_groups_count if
ext4_resize_fs() has added one or more block groups to the file system
--- which is when we might need to kick off the lazy init thread.

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html