linux-ext4 - Re: [PATCH 2/2] Ext3: return ENOMEM rather than EIO if sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130114034538.GB29329@thunk.org>
Date:	Sun, 13 Jan 2013 22:45:38 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Wang shilong <wangshilong1991@...il.com>, jack@...e.cz,
	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
	Wang Shilong <wangsl-fnst@...fujitsu.com>
Subject: Re: [PATCH 2/2] Ext3: return ENOMEM rather than EIO if sb_getblk
 fails

On Sat, Jan 12, 2013 at 08:43:42PM -0800, Greg KH wrote:
> On Thu, Jan 13, 2011 at 06:47:14PM +0800, Wang shilong wrote:
> > From: Wang Shilong <wangsl-fnst@...fujitsu.com>
> > 
> > It will be better to have ENOMEM return rather than EIO,because
> > the only reason that sb_getblk fails is allocation fails.
> > 
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
> 
> </formletter>

Did Wang Shilong bcc stable@...r.kernel.org?  He didn't need to send
this to linux-fsdevel@...r.kernel.org (the linux-ext4 list is
sufficient), but I didn't see anything which indicated he was trying
to submit this for inclusion in the stable kernel tree.

My personal opinion is this isn't an important enough patch to warrant
going into stable@...r.kernel.org, although I don't think it would do
any harm or is really dangerous, so I wouldn't object strongly if it did.

I did mark a similar change for ext4 as going to stable, but not
because of the error code change; but rather because I also fixed a
problem where an out-of-memory failure might result in the file system
getting marked as containing errors (and thus might cause an unneeded
fsck).

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html