linux-ext4 - Re: [PATCH 2/5] mke2fs: the -g option will now specify the clusters per block group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50F57171.6030701@redhat.com>
Date:	Tue, 15 Jan 2013 09:10:41 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Theodore Ts'o" <tytso@....edu>
CC:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	gnehzuil.liu@...il.com
Subject: Re: [PATCH 2/5] mke2fs: the -g option will now specify the clusters
 per block group

On 1/14/13 6:37 PM, Theodore Ts'o wrote:
> If bigalloc is enabled, then -g will specify the clusters per block
> group.  (If bigalloc is not enabled, then a cluster == a block, so the
> meaning of -g is not changed.)

This should be clearly documented in the man page as well, I think.

-Eric

> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> ---
>  misc/mke2fs.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 75d0e48..5cb49b3 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -1962,6 +1962,15 @@ profile_error:
>  		}
>  	}
>  
> +	/*
> +	 * If the bigalloc feature is enabled, then the -g option will
> +	 * specify the number of clusters per group.
> +	 */
> +	if (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) {
> +		fs_param.s_clusters_per_group = fs_param.s_blocks_per_group;
> +		fs_param.s_blocks_per_group = 0;
> +	}
> +
>  	if (inode_size == 0)
>  		inode_size = get_int_from_profile(fs_types, "inode_size", 0);
>  	if (!flex_bg_size && (fs_param.s_feature_incompat &
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html