linux-ext4 - Re: [PATCH 4/5] mke2fs: teach mke2fs to understand -b 4k and -C 256M

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50F571B3.8040500@redhat.com>
Date:	Tue, 15 Jan 2013 09:11:47 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Theodore Ts'o" <tytso@....edu>
CC:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	gnehzuil.liu@...il.com
Subject: Re: [PATCH 4/5] mke2fs: teach mke2fs to understand -b 4k and -C 256M

On 1/14/13 6:37 PM, Theodore Ts'o wrote:
> The -b and -C options now use parse_num_blocks2() insteda of strtol,
> so that users can specify -C 256M instead of the much less convenient
> -C 268435456.

Hm and -C isn't in the manpage at all.

Seems like the mke2fs manpage needs an update for bigalloc?

-Eric

> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> ---
>  misc/mke2fs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 5cb49b3..c16ab33 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -1324,10 +1324,10 @@ profile_error:
>  		    "b:cg:i:jl:m:no:qr:s:t:vC:DE:FG:I:J:KL:M:N:O:R:ST:U:V")) != EOF) {
>  		switch (c) {
>  		case 'b':
> -			blocksize = strtol(optarg, &tmp, 0);
> +			blocksize = parse_num_blocks2(optarg, -1);
>  			b = (blocksize > 0) ? blocksize : -blocksize;
>  			if (b < EXT2_MIN_BLOCK_SIZE ||
> -			    b > EXT2_MAX_BLOCK_SIZE || *tmp) {
> +			    b > EXT2_MAX_BLOCK_SIZE) {
>  				com_err(program_name, 0,
>  					_("invalid block size - %s"), optarg);
>  				exit(1);
> @@ -1345,9 +1345,9 @@ profile_error:
>  			cflag++;
>  			break;
>  		case 'C':
> -			cluster_size = strtoul(optarg, &tmp, 0);
> +			cluster_size = parse_num_blocks2(optarg, -1);
>  			if (cluster_size <= EXT2_MIN_CLUSTER_SIZE ||
> -			    cluster_size > EXT2_MAX_CLUSTER_SIZE || *tmp) {
> +			    cluster_size > EXT2_MAX_CLUSTER_SIZE) {
>  				com_err(program_name, 0,
>  					_("invalid cluster size - %s"),
>  					optarg);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html