linux-ext4 - Re: [PATCH] e2fslibs: fix llseek on i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130125021604.GB28908@thunk.org>
Date:	Thu, 24 Jan 2013 21:16:05 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Phillip Susi <psusi@...ntu.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fslibs: fix llseek on i386

On Fri, Jan 25, 2013 at 10:25:14AM +0800, Zheng Liu wrote:
> 
> This patch makes me consider my patches that dump a sparse file in
> debugfs.  In my patch [1] llseek64(2) is called to seek to the next
> data in target file.  So I believe ext2fs_llseek() is a better choice.
> I am happy to send a newer patch to fix it.  What do you think?
> 
> 1. http://www.spinics.net/lists/linux-ext4/msg36134.html

You're right, we should use ext2fs_llseek() for better portability.
Thanks,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html