lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Jan 2013 09:06:49 -0500 From: Theodore Ts'o <tytso@....edu> To: Ext4 Developers List <linux-ext4@...r.kernel.org> Cc: xi.wang@...il.com, Theodore Ts'o <tytso@....edu> Subject: [PATCH] debugfs: add sanity check to make sure we never shift 64 bits right In the tables which are used to parse the fields for the set_fields command, there should never be a entry which has a size set to 8 bytes, and two pointers defined. Not only would it result in undefined behavior in the compiled code, it doesn't make any sense and is definitely a bug. Reported-by: Xi Wang <xi.wang@...il.com> Signed-off-by: "Theodore Ts'o" <tytso@....edu> --- debugfs/set_fields.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/debugfs/set_fields.c b/debugfs/set_fields.c index 08bfd8d..5c86d74 100644 --- a/debugfs/set_fields.c +++ b/debugfs/set_fields.c @@ -389,7 +389,10 @@ static errcode_t parse_uint(struct field_set_info *info, char *field, n = num & mask; switch (size) { case 8: - *u.ptr64 = n; + /* Should never get here */ + fprintf(stderr, "64-bit field %s has a second 64-bit field\n" + "defined; BUG?!?\n", info->name); + *u.ptr64 = 0; break; case 4: *u.ptr32 = n; -- 1.7.12.rc0.22.gcdd159b -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists