linux-ext4 - Re: [PATCH 2/2] Ext3: remove a useless check for the function ext3_free_blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510765B1.7000100@gmail.com>
Date:	Mon, 28 Jan 2013 22:01:21 -0800
From:	Wang Shilong <wangshilong1991@...il.com>
To:	Jan Kara <jack@...e.cz>
CC:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/2] Ext3: remove a useless check for the function ext3_free_blocks_sb

于 2013-1-28 6:07, Jan Kara 写道:
> On Sat 26-01-13 14:58:31, Wang Shilong wrote:
>> From: Wang Shilong <wangsl-fnst@...fujitsu.com>
>>
>> Because 'block + count < block' always comes to false, it is useless
>> to have this check, just remove it.
>   As Andreas commented, the test is actually correct. BTW any reason why
> you sent the patch three times?
My linux run in the virtual machine..and the clock is wrong...so i send the patch not clarified correctly
in marc.info..when i find it..I correct it, but first time i correct the time as 2012....how stupid it was..:-[
so i send the patch three times...sorry to bother...

BTW ， may i have a question....
As we know the block to be freed can not be superblock and GDT..
I don't see any check about it in ext2/ext3/ext4....

Thanks,
Wang
>
> 								Honza
>
>> Signed-off-by: Wang Shilong <wangsl-fnst@...fujitsu.com>
>> ---
>>  fs/ext3/balloc.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
>> index 22548f5..c557f22 100644
>> --- a/fs/ext3/balloc.c
>> +++ b/fs/ext3/balloc.c
>> @@ -507,7 +507,6 @@ void ext3_free_blocks_sb(handle_t *handle, struct super_block *sb,
>>  	sbi = EXT3_SB(sb);
>>  	es = sbi->s_es;
>>  	if (block < le32_to_cpu(es->s_first_data_block) ||
>> -	    block + count < block ||
>>  	    block + count > le32_to_cpu(es->s_blocks_count)) {
>>  		ext3_error (sb, "ext3_free_blocks",
>>  			    "Freeing blocks not in datazone - "
>> -- 1.7.11.7
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html