linux-ext4 - Re: [PATCH 1/2] ext4: Don't allow quota mount options when quota feature enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130226131822.GA3359@quack.suse.cz>
Date:	Tue, 26 Feb 2013 14:18:22 +0100
From:	Jan Kara <jack@...e.cz>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] ext4: Don't allow quota mount options when quota
 feature enabled

On Mon 25-02-13 19:39:43, Ted Tso wrote:
> On Tue, Feb 26, 2013 at 12:36:08AM +0100, Jan Kara wrote:
> > So far we silently ignored when quota mount options were set while quota
> > feature was enabled. But this can create confusion in userspace when
> > mount options are set but silently ignored and also creates opportunities
> > for bugs when we don't properly test all quota types. Actually
> > ext4_mark_dquot_dirty() forgets to test for quota feature so it was
> > dependent on journaled quota options being set. OTOH ext4_orphan_cleanup()
> > tries to enable journaled quota when quota options are specified which is
> > wrong when quota feature is enabled.
> > 
> > Signed-off-by: Jan Kara <jack@...e.cz>
> 
> I've been using the quota mount options since it's the only way to
> test the quota patches when using an older version of the quota
> userspace package.
  Yeah, I know it's useful at moments to be able to use quota mount options
even with quota feature. But older quota tools behave strangely with quota
feature anyway at times so for production use I'd suggest at least version
4.01 anyway. That's why I decided forcing quota mount options off with
quota feature because that's going to cause the least confusion long term
IMHO.

> I can build a newer version of the userspace quota package for my own
> use (since version 4.01 isn't in Debian Testing yet nor Ubuntu yet),
> but we probably need to make sure we document that users may need to
> build their own version of the quota package.
  True, I guess adding that to mke2fs manpage would be appropriate?

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html