linux-ext4 - Re: [PATCH 1/2] ext4: Don't allow quota mount options when quota feature enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130302230406.GF22941@thunk.org>
Date:	Sat, 2 Mar 2013 18:04:06 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] ext4: Don't allow quota mount options when quota
 feature enabled

On Tue, Feb 26, 2013 at 12:36:08AM +0100, Jan Kara wrote:
> So far we silently ignored when quota mount options were set while quota
> feature was enabled. But this can create confusion in userspace when
> mount options are set but silently ignored and also creates opportunities
> for bugs when we don't properly test all quota types. Actually
> ext4_mark_dquot_dirty() forgets to test for quota feature so it was
> dependent on journaled quota options being set. OTOH ext4_orphan_cleanup()
> tries to enable journaled quota when quota options are specified which is
> wrong when quota feature is enabled.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html