linux-ext4 - Re: [PATCH] Ext2: do not mark_inode_dirty to avoid BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Mar 2013 08:43:10 +0800
From:	Wang Shilong <wangshilong1991@...il.com>
To:	Jan Kara <jack@...e.cz>, fanchaoting <fanchaoting@...fujitsu.com>
Cc:	tyhicks@...onical.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] Ext2: do not mark_inode_dirty to avoid BUG_ON


在 2013-3-14，上午7:09，Jan Kara <jack@...e.cz> 写道：

> On Tue 12-03-13 13:06:37, fanchaoting wrote:
>> From: Wang Shilong <wangsl-fnst@...fujitsu.com>
>> 
>> commit 8e3dffc651cb668e1ff4d8b89cc1c3dde7540d3b leads into
>> a regression that casue BUG_ON when unlinking inode.
>> 
>> Reported-by: tyhicks@...onical.com
>> Signed-off-by: Wang Shilong <wangsl-fnst@...fujitsu.com>
>  I ended up fixing the problem by the attached patch. It looks cleaner to
> me that way... Thanks for your fix anyway.

Sorry for delay reply, I am busy with my graduation project these two days.
However, your patch looks more reasonable than mine. 

Thanks very much to fanchaoting sending my patch out anyway.

Thanks,
Wang

> 
> 							Honza
>> ---
>> fs/ext2/balloc.c |    1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>> 
>> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
>> index 9f9992b..06d82fc 100644
>> --- a/fs/ext2/balloc.c
>> +++ b/fs/ext2/balloc.c
>> @@ -562,7 +562,6 @@ error_return:
>> 	if (freed) {
>> 		percpu_counter_add(&sbi->s_freeblocks_counter, freed);
>> 		dquot_free_block_nodirty(inode, freed);
>> -		mark_inode_dirty(inode);
>> 	}
>> }
>> 
>> -- 1.7.7.6 
>> 
>> 
>> 
>> 
> -- 
> Jan Kara <jack@...e.cz>
> SUSE Labs, CR
> <0001-ext2-Fix-BUG_ON-in-evict-on-inode-deletion.patch>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html