linux-ext4 - Re: [PATCH] ext4: fix journal callback list traversal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y5dfwg2r.fsf@openvz.org>
Date:	Fri, 22 Mar 2013 20:32:28 +0400
From:	Dmitry Monakhov <dmonakhov@...nvz.org>
To:	Theodore Ts'o <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org, bobijam@...mcloud.com
Subject: Re: [PATCH] ext4: fix journal callback list traversal

On Thu, 21 Mar 2013 12:16:53 -0400, Theodore Ts'o <tytso@....edu> wrote:
> On Thu, Mar 21, 2013 at 08:11:24PM +0400, Dmitry Monakhov wrote:
> > OOps. Sorry. I've sent wrong patch. Please ignore it. I'll send correct
> > version in a minute.
> 
> Yeah, I just noticed that it doesn't compile.  Also, it looks like the
> patch you sent wasn't actually checking the return value of
> ext4_journal_callback_try_del()?
Sorry for a long replay.... It takes me longer that a minute to fix all
that crap i've found. It is appeared that running xfstests plus freeze/unfrees
in a background opened an Pandora's box. First it is apeared that JBD2
has a bug since "Nov 6 2008". After that I've prepared incorrect patch
for jbd2 which corrupted journal and it is appeared that error handling
in ext4_fill_super is also broken. Nor than less patches are already available here:
http://patchwork.ozlabs.org/patch/230111/
http://patchwork.ozlabs.org/patch/230112/
http://patchwork.ozlabs.org/patch/230113/
And patched kernel survived with all my tests.
> 
> 						- Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html