linux-ext4 - Re: [PATCH] ext4: remove unneeded call to ext4_es_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOiN93msfJPVkE4OfodsBne5P7Ui7O0EfSdavbWK_-aZ-4crUA@mail.gmail.com>
Date:	Mon, 29 Apr 2013 14:10:42 +0530
From:	Ashish Sangwan <ashishsangwan2@...il.com>
To:	Ashish Sangwan <ashishsangwan2@...il.com>,
	"Theodore Ts'o" <tytso@....edu>,
	ext4 development <linux-ext4@...r.kernel.org>,
	wenqing.lz@...bao.com, Ashish Sangwan <a.sangwan@...sung.com>,
	Namjae Jeon <namjae.jeon@...sung.com>
Subject: Re: [PATCH] ext4: remove unneeded call to ext4_es_remove_extent in
 punch hole

On Sat, Apr 27, 2013 at 12:41 PM, Zheng Liu <gnehzuil.liu@...il.com> wrote:
> On Sat, Apr 27, 2013 at 12:20:22PM +0530, Ashish Sangwan wrote:
>> >The commit
>> > log is right before we use extent status tree to track all extent
>> > information.  In dev branch of ext4 tree, we track all extent status in
>> > status tree.  So we need to remove extent from status tree in punch
>> > hole.
>> I was of the opinion that filemap_write_and_wait_range will remove the
>> extent from status tree if its still there.
>> ok, I will check the dev branch.
>
> Ah, please bear with me.  In mainline kernel 3.9-rcX, we have used
> status tree to track all extent status.  You could also check 3.9-rcX
> kernel.  Please let me know if I miss something.
Hi Zheng,

Ok, I understood your point.
Currently, after step 2 of extent status tree, it houses _all_ the
extents and not just delayed extents.
This patch is not required now.

Regards,
Ashish
>
> Thanks,
>                                                 - Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html