linux-ext4 - Re: [PATCH] tests: clean up sed filtering of test output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <36AC98A8-1E7F-4644-903F-157654CD7CBB@dilger.ca>
Date:	Mon, 29 Apr 2013 18:35:40 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] tests: clean up sed filtering of test output

On 2013-04-29, at 6:27 PM, Andreas Dilger wrote:
> The sed filters for test outputs that are used to remove build and
> test specific information (such as version strings, dates, times,
> UUIDs) were unconditionally deleting the first line of output.  This
> would normally contain the tool version string, but in some cases
> contained other information that was being lost.  This can lead to
> difficulty debugging test failures.
> 
> The sed filtering has been changed to only remove the actual version
> strings.  As well, similar filter strings were duplicated throughout
> many scripts, and "sed" and "tr" were often called multiple times in
> a pipeline.  These have been consolidated into a single filter.sed
> file to avoid having to maintain these filters in multiple places.
> 
> In a few cases, accidentally deleted messages have been restored to
> the expect output for the tests.  In other cases, trivial whitespace
> has been changed in the expect files.

I found this while trying to test the "-R deprecation" patch.  It
was failing because the "deprecation" message was being eaten, but
the version line was not.

I was considering trying to make the output line-for-line compatible
with the old output, adding in a few "echo" lines to keep the old
whitespace the same, but it didn't seem worthwhile to add complexity
for this.  I don't think there are a huge number of m_* tests out
in the wild that will be broken, but I could be convinced otherwise.

The two patches aren't dependent on each other.

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html