[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130615224625.GA32754@thunk.org>
Date: Sat, 15 Jun 2013 18:46:25 -0400
From: Theodore Ts'o <tytso@....edu>
To: Andreas Dilger <adilger@...ger.ca>
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH] tests: clean up sed filtering of test output
On Mon, Apr 29, 2013 at 06:27:25PM -0600, Andreas Dilger wrote:
> The sed filters for test outputs that are used to remove build and
> test specific information (such as version strings, dates, times,
> UUIDs) were unconditionally deleting the first line of output. This
> would normally contain the tool version string, but in some cases
> contained other information that was being lost. This can lead to
> difficulty debugging test failures.
>
> The sed filtering has been changed to only remove the actual version
> strings. As well, similar filter strings were duplicated throughout
> many scripts, and "sed" and "tr" were often called multiple times in
> a pipeline. These have been consolidated into a single filter.sed
> file to avoid having to maintain these filters in multiple places.
>
> In a few cases, accidentally deleted messages have been restored to
> the expect output for the tests. In other cases, trivial whitespace
> has been changed in the expect files.
>
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>
Applied, thanks.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists