lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130729234425.GB3648@gmail.com> Date: Tue, 30 Jul 2013 07:44:25 +0800 From: Zheng Liu <gnehzuil.liu@...il.com> To: Theodore Ts'o <tytso@....edu> Cc: linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>, Zheng Liu <wenqing.lz@...bao.com> Subject: Re: [PATCH v2] ext4: remove the entry from es tree when bigalloc is enabled On Mon, Jul 29, 2013 at 12:21:51PM -0400, Theodore Ts'o wrote: > On Fri, Jul 26, 2013 at 07:42:06AM +0800, Zheng Liu wrote: > > From: Jan Kara <jack@...e.cz> > > > > Now in ext4_da_page_release_reservation() we remove the entry from es > > tree if to_release != 0. But there are two issues. One is that it is > > wrong when blocksize != pagesize, > > The commit description says that this is wrong, but I don't see > anything in the patch which addresses this. And could you state what > the impact is of this wrongness? Sorry for my bad description. As Jan said, this patch doesn't address any issue. It just makes the code clearly. After applied this patch, I still get the warning messages from ext4_da_release_space running xfstests #74 when blocksize = 1k. Thanks, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists