linux-ext4 - Re: [PATCH] ext4: add ratelimiting to ext4 messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131021094345.GA2313@gmail.com>
Date:	Mon, 21 Oct 2013 17:43:46 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Eric Sandeen <sandeen@...hat.com>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: add ratelimiting to ext4 messages

Hi Ted,

On Fri, Oct 18, 2013 at 02:59:55PM -0400, Theodore Ts'o wrote:
> On Fri, Oct 18, 2013 at 09:08:40AM -0500, Eric Sandeen wrote:
> > On 10/17/13 8:28 PM, Theodore Ts'o wrote:
> > > In the case of a storage device that suddenly disappears, or in the
> > > case of significant file system corruption, this can result in a huge
> > > flood of messages being sent to the console.  This can overflow the
> > > file system containing /var/log/messages, or if a serial console is
> > > configured, this can slow down the system so much that a hardware
> > > watchdog can end up triggering forcing a system reboot.
> > 
> > Just out of curiosity, after the fs shuts down, is there still a flood
> > of messages?  Shouldn't that clamp down on the errors?
> 
> Not if we are running with errors=continue.  There are some ugly
> patches in our tree which pipes error notifications to a netlink
> socket, which allows userspace to do something intelligent with
> errors, and because there are some errors where it's safe to continue
> (especially if you are willing to shut down block allocations to the
> block group where you don't trust the allocation bitmap), we tend to
> run with errors=continue.
> 
> I think I mentioned the errors->netlink feature a while back, but
> there wasn't a whole lot of excitement about it, and the patches
> definitely need a lot of cleanup before they would be ready for
> upstream merging.  If people are curious, I can look into getting the
> patches sent out, since we just finished rebasing them to 3.11.

That would be great if you could sent it out.  We are happy to review
and let it go into mainline kernel if it is also useful for others.

Thanks,
                                                - Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html