linux-ext4 - Re: [PATCH] ext2: Fix oops in ext2_get_block() called from ext2_quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131203211328.GB24466@thunk.org>
Date:	Tue, 3 Dec 2013 16:13:28 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-ext4@...r.kernel.org, Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH] ext2: Fix oops in ext2_get_block() called from
 ext2_quota_write()

On Tue, Dec 03, 2013 at 12:57:05PM +0100, Jan Kara wrote:
> ext2_quota_write() doesn't properly setup bh it passes to
> ext2_get_block() and thus we hit assertion BUG_ON(maxblocks == 0) in
> ext2_get_blocks() (or we could actually ask for mapping arbitrary number
> of blocks depending on whatever value was on stack).
> 
> Fix ext2_quota_write() to properly fill in number of blocks to map.
> 
> Reported-by: Christoph Hellwig <hch@...radead.org>
> Signed-off-by: Jan Kara <jack@...e.cz>

Looks good to me.

Reviewed-by: "Theodore Ts'o" <tytso@....edu>

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html