linux-ext4 - Re: [PATCH] create_inode: fix gcc -Wall complaints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140312034539.GC26898@thunk.org>
Date:	Tue, 11 Mar 2014 23:45:39 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Cc:	darrick.wong@...cle.com, liezhi.yang@...driver.com
Subject: Re: [PATCH] create_inode: fix gcc -Wall complaints

On Tue, Mar 11, 2014 at 11:41:10PM -0400, Theodore Ts'o wrote:
> We had several functions that were not returning zero on success.  Fix
> this.
> 
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>

One additional gcc -Wall nit which I have not yet fixed:

create_inode.c is using ext2fs_inline_data_init() which is currently a
private function defined in ext2fsP.h.

We either need to make this a publically exported interface (in which
case we have to guarantee that it is stable), or we need to find
another way to make the right thing happen here.

Darrick, Robert, do you have any thoughts or suggestions?

	       	    	      	    	   - Ted

P.S.  My bad for not doing a gcc -Wall run on the patches before
accepting them.  And in the future, I'd appreciate it if people who
are preparing patches do a "make gcc-wall" and make sure you're not
making things worse.  There are plenty of bugs that can be turned up
this way.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html