linux-ext4 - Re: [2/4 v2] e2fsck: make a prompt message simpler and thus translatable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Jun 2014 14:23:21 +0200
From:	Benno Schulenberg <bensberg@...temail.net>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [2/4 v2] e2fsck: make a prompt message simpler and thus translatable

On Wed, Jun 4, 2014, at 4:07, Theodore Ts'o wrote:
> You forgot to fix up the regression test suite f_extra_journal so
> "make check" doesn't fail.
> 
> I've taken care of it,

Thanks.

> but in general before sending patches, I'd
> appreicate a quick run of "make -j8 check"

Okay.

Running 'make check' now, I see these messages along the way:

mktemp: too few X's in template `r_64bit_big_expand.XXXXXX.tmp'
touch: missing file operand
Try `touch --help' for more information.
rm: missing operand
Try `rm --help' for more information.
r_64bit_big_expand: very large fs growth using ext4 w/64bit: skipped
mktemp: too few X's in template `r_bigalloc_big_expand.XXXXXX.tmp'
touch: missing file operand
Try `touch --help' for more information.
rm: missing operand
Try `rm --help' for more information.
r_bigalloc_big_expand: ext4 with bigalloc: skipped
mktemp: too few X's in template `r_ext4_big_expand.XXXXXX.tmp'
touch: missing file operand
Try `touch --help' for more information.
rm: missing operand
Try `rm --help' for more information.
r_ext4_big_expand: very large fs growth using ext4: skipped

That doesn't look intentional.
The contents of r_ext4_big_expand.log are:

very large fs growth using ext4 starting
dd: truncating at 2199023255552 bytes in output file `/tmp/e2fsprogs-tmp.I08Z35': File too large
using 
dd: opening `': No such file or directory

On this system, 'info mktemp' says:
"The last six characters of this string must be `XXXXXX'."

So by doing a 's/XXXXXX.tmp/tmp.XXXXXX/' in tests/scripts/resize_test
those messages disappear and 144 tests succeeded     0 tests failed.

Patch is coming up in a minute.

Benno

-- 
http://www.fastmail.fm - IMAP accessible web-mail

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html