linux-ext4 - Re: [ext4:dev 8/8] fs/ext4/indirect.c:1462 ext4_ind_remove_space() error: we previously assumed 'partial->bh' could be null (see line 1441)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 14 Jul 2014 06:00:45 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-ext4@...r.kernel.org
Subject: Re: [ext4:dev 8/8] fs/ext4/indirect.c:1462 ext4_ind_remove_space()
 error: we previously assumed 'partial->bh' could be null (see line 1441)

On Mon, Jul 14, 2014 at 09:03:37AM +0200, Lukáš Czerner wrote:
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev

> Hi Ted,
> 
> in which branch is it ? I can not find this commit anywhere in the
> ext4 tree.

It's on the tip of the dev tree, but remember, the dev branch is a
rewinding branch, so the commit id's are not stable.  Patches that are
behind the master branch are guaranteed to be stable, but at the
moment master == origin.

What happened is that I had just rewound the dev branch to reflect
v3.16-rc5, since Linus accepted the stable regression fixes right
before he released 3.16-rc5, and to fix the bug you pointed out in
"ext4: rearrange initialization to fix EXT4FS_DEBUG".

(Moving forward to v3.16-rc5 also means that we now have the mm fix
that was causing the data=journal fsx test failures.)

At the moment the commit is 14e4f8cecbc4e (which is the tip of dev).
I don't plan to make any more changes for the three patches currently
on dev:

14e4f8c ext4: fix punch hole on files with indirect mapping
9f2fc8c ext4: remove metadata reservation checks
07dd825 ext4: rearrange initialization to fix EXT4FS_DEBUG

although I wouldn't be surprised if we get more review comments or
find issues with 9f2fc8c and 14e4f8c that require that we fix them up.  :-)

Also as a reminder (which you probably know, but this may be useful
for other newer ext4 developers on the list), the dev branch is
(mostly) a dual of the state of the patches on the ext4 patch queue:

https://ext4.wiki.kernel.org/index.php/Ext4_patchsets#The_ext4_patch_queue

(The reason why I say "mostly" is that I'm not always that good about
making sure I keep the timestamps file up to date, so the instructions
described in the ext4 wiki don't *always* result in exactly the same
commit id's.  Most people don't seem to care, but if this is a
problem, let me know and I can be more anal about updating the
timestamp file when I push out changes to the ext4 patch queue's git
tree.)

Cheers,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html