linux-ext4 - Re: [PATCH -v2] ext4: rearrange initialization to fix EXT4FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140714115623.GC8935@thunk.org>
Date:	Mon, 14 Jul 2014 07:56:23 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH -v2] ext4: rearrange initialization to fix EXT4FS_DEBUG

On Mon, Jul 14, 2014 at 10:04:47AM +0200, Lukáš Czerner wrote:
> > +	block = ext4_count_free_clusters(sb);
> > +	ext4_free_blocks_count_set(sbi->s_es, block);
> 
> 
> This does not seem right. block is in cluster units so we need to
> convert.
> 
> 	ext4_free_blocks_count_set(sbi->s_es, EXT4_C2B(sbi, blocks));
> 
> Otherwise it looks good to me.

Thanks, for catching this!   II've fixed up the patch on the ext4 git tree.

					- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html