linux-ext4 - Re: [PATCH -v2] ext4: rearrange initialization to fix EXT4FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1407141409210.13527@localhost.localdomain>
Date:	Mon, 14 Jul 2014 14:09:51 +0200 (CEST)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	"Theodore Ts'o" <tytso@....edu>
cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH -v2] ext4: rearrange initialization to fix EXT4FS_DEBUG

On Mon, 14 Jul 2014, Theodore Ts'o wrote:

> Date: Mon, 14 Jul 2014 07:56:23 -0400
> From: Theodore Ts'o <tytso@....edu>
> To: Lukáš Czerner <lczerner@...hat.com>
> Cc: Ext4 Developers List <linux-ext4@...r.kernel.org>
> Subject: Re: [PATCH -v2] ext4: rearrange initialization to fix EXT4FS_DEBUG
> 
> On Mon, Jul 14, 2014 at 10:04:47AM +0200, Lukáš Czerner wrote:
> > > +	block = ext4_count_free_clusters(sb);
> > > +	ext4_free_blocks_count_set(sbi->s_es, block);
> > 
> > 
> > This does not seem right. block is in cluster units so we need to
> > convert.
> > 
> > 	ext4_free_blocks_count_set(sbi->s_es, EXT4_C2B(sbi, blocks));
> > 
> > Otherwise it looks good to me.
> 
> Thanks, for catching this!   II've fixed up the patch on the ext4 git tree.
> 
> 					- Ted

In that case, you can add.

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Thanks!
-Lukas