linux-ext4 - Re: [PATCH] ext4: make ext4_has_inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140715140852.GA1491@thunk.org>
Date:	Tue, 15 Jul 2014 10:08:52 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	linux-ext4@...r.kernel.org, Ian Nartowicz <claws@...towicz.co.uk>,
	Tao Ma <tm@....ma>,
	"Darrick J. Wong" <darrick.wong@...cle.com>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [PATCH] ext4: make ext4_has_inline_data() as a inline function

On Wed, Jun 04, 2014 at 03:11:11PM +0800, Zheng Liu wrote:
> Now ext4_has_inline_data() is used in wide spread codepaths.  So we need
> to make it as a inline function to avoid burning some CPU cycles.
> 
> text size (bytes):
> vanilla: 10350562
> patched: 10384933 (+0.33%)

This represents a difference of 34k, which was over 10% the text size
of ext4.o --- so this surprised me greatly.  I just did my own
testing, and difference I see is 117 bytes:

         text	  data	    bss     dec	    hex	filename
before: 326110	  19258	   5528	 350896	  55ab0	fs/ext4/ext4.o
after:  326227	  19258	   5528	 351013	  55b25	fs/ext4/ext4.o

So I'm going to adjust the patch include these numbers, which are much
less likely to cause embedded people to complain about a large
increase in code bloat.  :-)

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html