linux-ext4 - RE: [PATCH v2] ext4: remove readpage() check up for mmap file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <100D68C7BA14664A8938383216E40DE0407A9B2C@FMSMSX114.amr.corp.intel.com>
Date:	Tue, 15 Jul 2014 14:16:40 +0000
From:	"Wilcox, Matthew R" <matthew.r.wilcox@...el.com>
To:	Theodore Ts'o <tytso@....edu>,
	Zhang Zhen <zhenzhang.zhang@...wei.com>
CC:	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"wangnan0@...wei.com" <wangnan0@...wei.com>,
	"Zwisler, Ross" <ross.zwisler@...el.com>
Subject: RE: [PATCH v2] ext4: remove readpage() check up for mmap file

Are you sure about the origins of that check, Ted?  It's not there in current ext2, and current XIP code calls the generic xip_file_mmap() method, not an ext2/4 specific one.

In any case, yes, no objection from my side to removing this check.
________________________________________
From: Theodore Ts'o [tytso@....edu]
Sent: July 15, 2014 6:43 AM
To: Zhang Zhen
Cc: linux-ext4@...r.kernel.org; wangnan0@...wei.com; Zwisler, Ross; Wilcox, Matthew R
Subject: Re: [PATCH v2] ext4: remove readpage() check up for mmap file

On Thu, Jul 03, 2014 at 02:18:31PM +0800, Zhang Zhen wrote:
> There is no kind of file does not supply page reading function.

The code in question originally came from ext2, when the a_ops used in
XIP mode did not have a readpage function.  And since there is an
outstanding XIP patch set that Matthew Wilcox has been working on, I
was going to NACK this.  Howeveer, it looks like the lines in question
are getting removed in the most recent version of the XIP patch set
that I've seen, so it it seems the only problem is this will cause a
minor patch conflict with XIP.

So I'll accept this, and assume the XIP folks aren't going to object....

                                        - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html