linux-ext4 - Re: [PATCH 11/24] e2fsck: free ctx->fs, not fs, at the end of fsck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140725011409.GB1865@thunk.org>
Date:	Thu, 24 Jul 2014 21:14:09 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 11/24] e2fsck: free ctx->fs, not fs, at the end of fsck

On Fri, Jul 18, 2014 at 03:53:35PM -0700, Darrick J. Wong wrote:
> When we call ext2fs_close_free at the end of main(), we need to supply
> the address of ctx->fs, because the subsequent e2fsck_free_context
> call will try to access ctx->fs (which is now set to a freed block) to
> see if it should free the directory block list.  This is clearly not
> desirable, so fix the problem.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html