linux-ext4 - Re: [PATCH 12/24] e2fsck: force all block allocations to use block_found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140725021853.GC1865@thunk.org>
Date:	Thu, 24 Jul 2014 22:18:53 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 12/24] e2fsck: force all block allocations to use
 block_found_map

On Fri, Jul 18, 2014 at 03:53:41PM -0700, Darrick J. Wong wrote:
> During the later passes of efsck, we sometimes need to allocate and
> map blocks into a file.  This can happen either by fsck directly
> calling new_block() or indirectly by the library calling new_block
> because it needs to allocate a block for lower level metadata (bmap2()
> with BMAP_SET; block_iterate3() with BLOCK_CHANGED).
> 
> We need to force new_block to allocate blocks from the found block
> map, because the FS block map could be inaccurate for various reasons:
> the map is wrong, there are missing blocks, the checksum failed, etc.
> 
> Therefore, any time fsck does something that could to allocate blocks,
> we need to intercept allocation requests so that they're sourced from
> the found block map.  Remove the previous code that swapped bitmap
> pointers as this is now unneeded.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html