linux-ext4 - Re: [PATCH 13/24] e2fsck: fix off-by-one bounds check on group number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140725022011.GD1865@thunk.org>
Date:	Thu, 24 Jul 2014 22:20:11 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 13/24] e2fsck: fix off-by-one bounds check on group number

On Fri, Jul 18, 2014 at 03:53:48PM -0700, Darrick J. Wong wrote:
> Since fs->group_desc_count is the number of block groups, the number
> of the last group is always one less than this count.  Fix the bounds
> check to reflect that.
> 
> This flaw shouldn't have any user-visible side effects, since the
> block bitmap test based on last_grp later on can handle overbig block
> numbers.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html