linux-ext4 - Re: [PATCH 1/2] jbd2: jbd2_log_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140916185130.GL6205@thunk.org>
Date:	Tue, 16 Sep 2014 14:51:30 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] jbd2: jbd2_log_wait_for_space improve error detetcion

On Sun, Sep 14, 2014 at 04:38:56PM +0400, Dmitry Monakhov wrote:
> If EIO happen after we have drop j_state_lock so it is reasonable to move this check under
> i_sate_lock critical section. This patch helps to  prevent false positive complain after EIO

Thanks, applied.  I adjusted the commit description slightly:

    If EIO happens after we have dropped j_state_lock, we won't notice
    that the journal has been aborted.  So it is reasonable to move this
    check after we have grabbed the j_checkpoint_mutex and re-grabbed the
    j_state_lock.  This patch helps to prevent false positive complain
    after EIO.

Cheers,

					- Ted

P.S.  Welcome back!  Glad to see you are safe.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html