[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140916185639.GM6205@thunk.org>
Date: Tue, 16 Sep 2014 14:56:39 -0400
From: Theodore Ts'o <tytso@....edu>
To: Christoph Lameter <cl@...ux.com>
Cc: Andreas Dilger <adilger@...ger.ca>, linux-mm <linux-mm@...ck.org>,
linux-ext4@...r.kernel.org, hughd@...gle.com,
Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: Best way to pin a page in ext4?
On Tue, Sep 16, 2014 at 01:34:37PM -0500, Christoph Lameter wrote:
> On Tue, 16 Sep 2014, Theodore Ts'o wrote:
>
> > > It doesn't seem unreasonable to just grab an extra refcount on the pages
> > > when they are first loaded.
> >
> > Well yes, but using mlock_vma_page() would be a bit more efficient,
> > and technically, more correct than simply elevating the refcount.
>
> mlocked pages can be affected by page migration. They are not
> pinned since POSIX only says that the pages must stay in memory. So the OS
> is free to move them around physical memory.
And indeed, that would be a better reason to use mlock_vma_page()
rather than elevating the refcount; we just need the page to stay in
memory. If the mm system needs to move the page around to coalesce
for hugepages, or some such, that's fine.
(And so the subject line in my original post is wrong; apologies, I'm
a fs developer, not a mm developer, and so I used the wrong
terminology.)
Cheers,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists