linux-ext4 - Re: [PATCH] ext4: Fix overflow when updating superblock backups after resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141028204059.GC20378@thunk.org>
Date:	Tue, 28 Oct 2014 16:40:59 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix overflow when updating superblock backups
 after resize

On Wed, Oct 22, 2014 at 05:00:47PM +0200, Lukáš Czerner wrote:
> On Wed, 22 Oct 2014, Jan Kara wrote:
> > When there are no meta block groups update_backups() will compute the
> > backup block in 32-bit arithmetics thus possibly overflowing the block
> > number and corrupting the filesystem. OTOH filesystems without meta
> > block groups larger than 16 TB should be rare. Fix the problem by doing
> > the counting in 64-bit arithmetics.
> 
> Looks good, thanks.
> 
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html