linux-ext4 - Re: [PATCH] ext4: Fix overflow when updating superblock backups after resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1410221700200.2250@localhost.localdomain>
Date:	Wed, 22 Oct 2014 17:00:47 +0200 (CEST)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Jan Kara <jack@...e.cz>
cc:	Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix overflow when updating superblock backups
 after resize

On Wed, 22 Oct 2014, Jan Kara wrote:

> Date: Wed, 22 Oct 2014 16:29:08 +0200
> From: Jan Kara <jack@...e.cz>
> To: Ted Tso <tytso@....edu>
> Cc: linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>,
>     stable@...r.kernel.org
> Subject: [PATCH] ext4: Fix overflow when updating superblock backups after
>     resize
> 
> When there are no meta block groups update_backups() will compute the
> backup block in 32-bit arithmetics thus possibly overflowing the block
> number and corrupting the filesystem. OTOH filesystems without meta
> block groups larger than 16 TB should be rare. Fix the problem by doing
> the counting in 64-bit arithmetics.

Looks good, thanks.

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

> 
> Coverity-id: 741252
> CC: stable@...r.kernel.org
> Signed-off-by: Jan Kara <jack@...e.cz>
> ---
>  fs/ext4/resize.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
> index f298c60f907d..ca4588388fc3 100644
> --- a/fs/ext4/resize.c
> +++ b/fs/ext4/resize.c
> @@ -1081,7 +1081,7 @@ static void update_backups(struct super_block *sb, int blk_off, char *data,
>  			break;
>  
>  		if (meta_bg == 0)
> -			backup_block = group * bpg + blk_off;
> +			backup_block = ((ext4_fsblk_t)group) * bpg + blk_off;
>  		else
>  			backup_block = (ext4_group_first_block_no(sb, group) +
>  					ext4_bg_has_super(sb, group));
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html