linux-ext4 - Re: [PATCH] ext4: Bail out from make_indexed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141030142405.GA31927@thunk.org>
Date:	Thu, 30 Oct 2014 10:24:05 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Bail out from make_indexed_dir() on first error

On Thu, Oct 23, 2014 at 05:18:53PM +0200, Jan Kara wrote:
> When ext4_handle_dirty_dx_node() or ext4_handle_dirty_dirent_node()
> fail, there's really something wrong with the fs and there's no point in
> continuing further. Just return error from make_indexed_dir() in that
> case. Also initialize frames array so that if we return early due to
> error, dx_release() doesn't try to dereference uninitialized memory
> (which could happen also due to error in do_split()).
> 
> Coverity-id: 741300
> Signed-off-by: Jan Kara <jack@...e.cz>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html