linux-ext4 - Re: [PATCH] ext4: Bail early when clearing inode journal flag fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141030143656.GB31927@thunk.org>
Date:	Thu, 30 Oct 2014 10:36:56 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Bail early when clearing inode journal flag fails

On Thu, Oct 23, 2014 at 03:05:43PM +0200, Jan Kara wrote:
> When clearing inode journal flag, we call jbd2_journal_flush() to force
> all the journalled data to their final locations. Currently we ignore
> when this fails and continue clearing inode journal flag. This isn't a
> big problem because when jbd2_journal_flush() fails, journal is likely
> aborted anyway. But it can still lead to somewhat confusing results so
> rather bail out early.
> 
> Coverity-id: 989044
> Signed-off-by: Jan Kara <jack@...e.cz>

Applied, thanks.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html