linux-ext4 - Re: [PATCH 17/22] ext4 crypto: partial update to namei.c for fname crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150412050636.GJ6540@thunk.org>
Date:	Sun, 12 Apr 2015 01:06:36 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	jaegeuk@...nel.org, mhalcrow@...gle.com,
	Uday Savagaonkar <savagaon@...gle.com>,
	Ildar Muslukhov <ildarm@...gle.com>
Subject: Re: [PATCH 17/22] ext4 crypto: partial update to namei.c for fname
 crypto

On Wed, Apr 08, 2015 at 11:44:05AM -0600, Andreas Dilger wrote:
> > +				if (ctx == NULL) {
> > +					/* Directory is not encrypted */
> > +					while (len--)
> > +						printk("%c", *name++);
> 
> This is a bit strange, why not use "printk("%*.s", len, name)"?

This was copied from grotty debug code that no one has really cleaned
up in a long time.  That's a good idea, thanks.

      	     	    	     	  - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html