linux-ext4 - Re: [PATCH 1/2] ext4: Recalculate journal credits as inode depth changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150615042256.GG15793@thunk.org>
Date:	Mon, 15 Jun 2015 00:22:56 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] ext4: Recalculate journal credits as inode depth
 changes

On Tue, Jun 09, 2015 at 08:58:45AM +0200, Lukas Czerner wrote:
> Currently in ext4_alloc_file_blocks() the number of credits is
> calculated only once before we enter the allocation loop. However within
> the allocation loop the extent tree depth can change, hence the number
> of credits needed can increase potentially exceeding the number of credits
> reserved in the handle which can cause journal failures.
> 
> Fix this by recalculating number of credits when the inode depth
> changes. Note that even though ext4_alloc_file_blocks() is only
> currently used by extent base inodes we will avoid recalculating number
> of credits unnecessarily in the case of indirect based inodes.
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html