linux-ext4 - Re: [PATCH 2/2] ext4: Wait for existing dio workers in ext4_alloc_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150615042554.GH15793@thunk.org>
Date:	Mon, 15 Jun 2015 00:25:54 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/2] ext4: Wait for existing dio workers in
 ext4_alloc_file_blocks()

On Tue, Jun 09, 2015 at 08:58:46AM +0200, Lukas Czerner wrote:
> Currently existing dio workers can jump in and potentially increase
> extent tree depth while we're allocating blocks in
> ext4_alloc_file_blocks(). This may cause us to underestimate the number
> of credits needed for the transaction because the extent tree depth can
> change after our estimation.
> 
> Fix this by waiting for all the existing dio workers in the same way as
> we do it in ext4_punch_hole. We've seen errors caused by this in xfstest
> generic/299, however it's really hard to reproduce.
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html