linux-ext4 - Re: [PATCH v2] generic: test I/O on dm error device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160323032531.GN11419@eguan.usersys.redhat.com>
Date:	Wed, 23 Mar 2016 11:25:31 +0800
From:	Eryu Guan <eguan@...hat.com>
To:	Dave Chinner <david@...morbit.com>
Cc:	fstests@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2] generic: test I/O on dm error device

On Wed, Mar 23, 2016 at 01:53:27PM +1100, Dave Chinner wrote:
> On Tue, Mar 15, 2016 at 04:12:14PM +0800, Eryu Guan wrote:
> > This is a test that performs simple I/O on dm error device, which
> > returns EIO on all I/O request.
> > 
> > This is motivated by an ext4 bug that crashes kernel on error path when
> > trying to update atime. Following kernel patch should fix the issue
> > 
> >   ext4: fix NULL pointer dereference in ext4_mark_inode_dirty()
> > 
> > Signed-off-by: Eryu Guan <eguan@...hat.com>
> > ---
> 
> Fails with:
> 
> @@ -1,2 +1,6 @@
>  QA output created by 338
>   Silence is golden
>   +specified blocksize 1024 is less than device physical sector size 4096
>   +switching to logical sector size 512
>   +mkfs.xfs: /dev/mapper/error-test appears to contain an existing filesystem (xfs).
>   +mkfs.xfs: Use the -f option to force overwrite.
> 
> And then it failed to clean up properly and caused all sorts of
> subsequent problems.

Test passed for me, seems it has something to do with the "physical
sector size 4096" device. I'll look into it. Thanks for the review!

Eryu
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html