linux-ext4 - Re: [PATCH] common/rc: improve _require_metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160818152620.GC27776@eguan.usersys.redhat.com>
Date:   Thu, 18 Aug 2016 23:26:20 +0800
From:   Eryu Guan <eguan@...hat.com>
To:     Eric Whitney <enwlinux@...il.com>
Cc:     fstests@...r.kernel.org, linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH] common/rc: improve _require_metadata_journaling() for
 ext4

On Thu, Aug 18, 2016 at 10:42:53AM -0400, Eric Whitney wrote:
> The code in _require_metadata_journaling() currently rejects ext4 file
> systems that have been created without a journal.  However, an ext4
> file system with a journal should also be rejected if the journal is
> not loaded and made available for use at mount time.
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>
> ---
>  common/rc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 3fb0600..9a3c9bd 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3057,6 +3057,9 @@ _require_metadata_journaling()
>  		_require_dumpe2fs
>  		$DUMPE2FS_PROG -h $DEV 2>&1 | grep -q has_journal || \
>  			_notrun "$FSTYP on $DEV not configured with metadata journaling"
> +		# ext4 may not have loaded a journal
> +		echo $MOUNT_OPTIONS | grep -q noload && \
> +			_notrun "$FSTYP on $DEV not mounted with metadata journaling"

I think this can be done by the new helper _exclude_scratch_mount_option
which was introduced recently, e.g.

_exclude_scratch_mount_option "noload"

Thanks,
Eryu

>  		;;
>  	*)
>  		# by default we pass; if you need to, add your fs above!
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html