linux-ext4 - Re: [PATCH] common/rc: improve _require_metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160819165604.GB1903@localhost.localdomain>
Date:   Fri, 19 Aug 2016 12:56:04 -0400
From:   Eric Whitney <enwlinux@...il.com>
To:     Eryu Guan <eguan@...hat.com>
Cc:     Eric Whitney <enwlinux@...il.com>, fstests@...r.kernel.org,
        linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH] common/rc: improve _require_metadata_journaling() for
 ext4

> 
> I think this can be done by the new helper _exclude_scratch_mount_option
> which was introduced recently, e.g.
> 
_exclude_scratch_mount_option "noload"

This function would be better named if it didn't include "_scratch", since
it isn't scratch-specific.  That would make it easier for the occasional
contributor/reader to recognize it for what it is at a glance.

Also, its header comment references MKFS_OPTIONS rather than MOUNT_OPTIONS.

Thanks,
Eric

> 
> Thanks,
> Eryu

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html