linux-ext4 - [PATCH] generic/135: redirect stderr from _scratch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160818150456.GB14069@localhost.localdomain>
Date:   Thu, 18 Aug 2016 11:04:56 -0400
From:   Eric Whitney <enwlinux@...il.com>
To:     fstests@...r.kernel.org
Cc:     linux-ext4@...r.kernel.org, tytso@....edu
Subject: [PATCH] generic/135: redirect stderr from _scratch_mkfs

In generic/135, benign warning message output from _scratch_mkfs on
stderr can cause a golden output mismatch, as can occur when testing
an ext4 bigalloc file system.  It's the only generic test that does not
also redirect stderr when directing _scratch_mkfs' stdout to /dev/null.
Since error output from _scratch_mkfs doesn't seem important to the
overall intent of the test, there should be no harm in making its
stderr handling consistent.

Signed-off-by: Eric Whitney <enwlinux@...il.com>
---
 tests/generic/135 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/135 b/tests/generic/135
index 52418f6..14b8132 100755
--- a/tests/generic/135
+++ b/tests/generic/135
@@ -41,7 +41,7 @@ _supported_os Linux IRIX

 _require_odirect
 _require_scratch
-_scratch_mkfs >/dev/null
+_scratch_mkfs >/dev/null 2>&1
 _scratch_mount

 cd $SCRATCH_MNT
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html