[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20160819052106.GC10888@thunk.org>
Date: Fri, 19 Aug 2016 01:21:06 -0400
From: Theodore Ts'o <tytso@....edu>
To: Dmitry Monakhov <dmonakhov@...nvz.org>
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH 6/6] Add dockerfile
On Fri, Aug 19, 2016 at 12:54:11AM +0400, Dmitry Monakhov wrote:
> Dockerfile is good way to create build environments
> Let's keep it as a reference build script.
>
> XXX: Currently Ted does not have hub.docker account
> so this docker file points to my hub. Should be updated.
I guess I'm a little confused about how this Dockerfile works. First
of all, says "From Debian", so I guess the idea is to be based on an
unspecified version of Debian (why not debian:jessie?). But then it
has apt-get commands? How does that work?
And if the idea is to fetch a prebuilt docker image, and we're running
it with docker run --privilege, I'm not sure what value using docker
run is really providing. We're not using the docker container
features. And typing
docker run -i -t --privileged ... \
"kvm-xfstests.sh --kernel /tmp/bzImage --update-files --update-xfstests-tar smoke"
Is just *awkward*. The whole point is to let kvm-xfstests read the
kernel from your ~/.config/gce-xfstests, so your work flow can be
something like this:
git am -s ~/mbox/patch.mbox
../make-ext4 # shortcut for something like "make O=/build/ext4 -j16"
kvm-xfstests smoke # ~/.config/gce-xfststs sets GCE_KERNEL=/build/ext4
needing to type a long docker run command doesn't seem to add any
value.
Confused,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists