linux-ext4 - Re: [PATCH] fscrypto: remove unneeded Kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1c3502a-0364-fc31-fa7f-19125f7e0413@nod.at>
Date:   Mon, 24 Oct 2016 22:41:08 +0200
From:   Richard Weinberger <richard@....at>
To:     Eric Biggers <ebiggers@...gle.com>, linux-fsdevel@...r.kernel.org
Cc:     linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
        tytso@....edu, jaegeuk@...nel.org
Subject: Re: [PATCH] fscrypto: remove unneeded Kconfig dependencies

On 24.10.2016 22:17, Eric Biggers wrote:
> SHA256 and ENCRYPTED_KEYS are not needed.  CTR shouldn't be needed
> either, but I left it for now because it was intentionally added by
> commit 71dea01ea2ed ("ext4 crypto: require CONFIG_CRYPTO_CTR if ext4
> encryption is enabled").  So it sounds like there may be a dependency
> problem elsewhere, which I have not been able to identify specifically,
> that must be solved before CTR can be removed.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Reviewed-by: Richard Weinberger <richard@....at>

FWIW, Strictly speaking we could also get rid of the dependency on BLOCK.
Only very few functions in fs/crypto/crypto.c use block specific functions,
these could be placed in a different file.
The use case would be very small systems with UBIFS and encrypted files.
i.e. kexec() style bootloaders.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html