linux-ext4 - Re: [PATCH] ext4: don't BUG when truncating encrypted inodes on the orphan list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMGZ=GrnLVSX5xEzn5m4ASsiBhpWv8U8SL0im-xNway9pNktw@mail.gmail.com>
Date:   Mon, 13 Feb 2017 03:58:46 +0100
From:   Vegard Nossum <vegard.nossum@...il.com>
To:     "Theodore Ts'o" <tytso@....edu>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: don't BUG when truncating encrypted inodes on the
 orphan list

On 13 February 2017 at 01:31, Theodore Ts'o <tytso@....edu> wrote:
> As a wishlist item, it would be nice if your web reports included
> hotlinks from the addresses / symbol_name+offset to the git tree
> sources at the indicated line number.  For example:
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/fs/ext4/inode.c?id=07f00f06ba9a5533d6650d46d3e938f6cbeee97e#n3738
>
> One of the crash dump analysis tool at $WORK does that, and it saves a
> huge amount of developer time.
>
> Anyway, at least for the ones where there is an explicit BUG_ON with a
> line number, I should revisit your reports to see if I might not be
> able clear out more of them.  (Is there a list of which ones are still
> valid?)
>
> But for ones where there is a stack trace without a BUG_INFO or
> WARN_ON to give me a line number, any chance you could use addr2line
> or otherwise make the kernel (with debugging information compiled in)
> available?

Those reports all include the hotlinks actually. The one for this problem was:

http://139.162.151.198/f/ext4/5bdefda69f39b2f2c56d9b67d5b7d9e2cc8dfd5f/

If you go to the stack trace then any line containing a kernel address
that can be addr2lined appears in green and clicking it should expand
a link to git.kernel.org. It does probably need javascript to work.

I'll get around to rerunning all the testcases soon on a recent kernel.


Vegard