linux-ext4 - Re: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7280edbc-ba2b-2b72-680a-9408a8e764b9@intel.com>
Date:   Thu, 16 Feb 2017 09:27:52 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Dave Hansen <dave.hansen@...ux.intel.com>,
        akpm@...ux-foundation.org
Cc:     keescook@...gle.com, mawilcox@...rosoft.com,
        linux-nvdimm@...ts.01.org, linux-xfs@...r.kernel.org,
        linux-mm@...ck.org, kirill.shutemov@...ux.intel.com, jack@...e.com,
        dan.j.williams@...el.com, linux-ext4@...r.kernel.org,
        ross.zwisler@...ux.intel.com, vbabka@...e.cz,
        alexander.kapshuk@...il.com
Subject: Re: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear()



On 02/16/2017 08:42 AM, Dave Hansen wrote:
> On 02/15/2017 12:31 PM, Dave Jiang wrote:
>> The fix introduced by e4decc90 to fix the UP case for 32bit x86, however
>> that broke the SMP case that was working previously. Add ifdef so the dummy
>> function only show up for 32bit UP case only.
> 
> Could you elaborate a bit on how it broke things?

So originally 0-day build found that commit a10a1701 (mm, x86: add
support for PUD-sized transparent hugepages) is breaking 32bit x86 UP
config because native_pud_clear() was missing to satisfy
arch/x86/include/asm/pgtable.h. I added a dummy function to satisfy that
with commit e4decc90 (mm,x86: native_pud_clear missing on i386 build).
However in the process of doing that, I broke the 32bit x86 SMP config
that was working before.

> 
>> Fix: e4decc90 mm,x86: native_pud_clear missing on i386 build
> 
> Which tree is that in, btw?
> 
linux-next-20170214 I believe