linux-ext4 - Re: [PATCH] e2fsprogs: remove duplicate default values in mke2fs.conf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170216162847.5qjwfr6lvy6rdzgv@thunk.org>
Date:   Thu, 16 Feb 2017 11:28:47 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Xose Vazquez Perez <xose.vazquez@...il.com>
Cc:     EXT4 ml <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsprogs: remove duplicate default values in mke2fs.conf

On Sat, Feb 11, 2017 at 04:15:35PM +0100, Xose Vazquez Perez wrote:
> @@ -12,11 +12,9 @@
>  	}
>  	ext4 = {
>  		features = has_journal,extent,huge_file,flex_bg,uninit_bg,64bit,dir_nlink,extra_isize
> -		inode_size = 256
>  	}
>  	ext4dev = {
>  		features = has_journal,extent,huge_file,flex_bg,uninit_bg,inline_data,64bit,dir_nlink,extra_isize
> -		inode_size = 256
>  		options = test_fs=1
>  	}
>  	small = {

These are duplicate values (although they don't do any harm).

> @@ -47,6 +45,5 @@
>  		blocksize = -1
>  	}
>  	hurd = {
> -	     blocksize = 4096
>  	     inode_size = 128
>  	}

This value *is* required.  The Hurd has a re-implementation of the
ext2/3/4 file system, which is very limited.  One of its limitations
is the block size must be equal to the page size (and it only works on
x86.)   So the "blocksize = 4096" is required so that:

	mke2fs -o hurd /tmp/foo.img 1024

will use a 4k block size even for small file systems.

     	      	    	      - Ted