linux-ext4 - Re: e4crypt: fix error handling for KEYCTL_GET_KEYRING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170413154457.qjxfbbnnhwj23xnn@thunk.org>
Date:   Thu, 13 Apr 2017 11:44:57 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Joe Richey <joerichey94@...il.com>
Cc:     linux-ext4@...r.kernel.org, Michael Halcrow <mhalcrow@...gle.com>,
        Joe Richey <joerichey@...gle.com>
Subject: Re: e4crypt: fix error handling for KEYCTL_GET_KEYRING_ID

On Mon, Apr 03, 2017 at 04:52:50PM +0000, Joe Richey wrote:
> From: Joe Richey <joerichey@...gle.com>
> 
> Due to some interesting behaviour in keyctl (as described in the
> comments), we use KEYCTL_GET_KEYRING_ID to translate the special value
> of KEY_SPEC_SESSION_KEYRING to a real keyring id. However, how we
> currently do this is flawed in two ways.
> 
> First, if KEYCTL_GET_KEYRING_ID fails, we don't detect it as it returns
> -1 and zero is used for an error value in get_keyring_id. Second, if the
> user specifies "-k @s" the translation never runs and the undesireable
> behavior occurs.
> 
> These are both fixed by doing the translation outside of get_keyring_id.
> 
> Signed-off-by: Joe Richey <joerichey@...gle.com>

Thanks, applied.

						- Ted